[pecl-networking-ssh2] master: use zval_ptr_dtor_nogc instead of zval_dtor alias
| From: | Remi Collet via Casper Langemeijer | Date: | Wed, 14 Oct 2026 19:43:39 +0000 |
| Subject: | [pecl-networking-ssh2] master: use zval_ptr_dtor_nogc instead of zval_dtor alias | ||
| Groups: | php.pecl.cvs | ||
| Request: | Send a blank email to pecl-cvs+get-28695@lists.php.net to get a copy of this message | ||
Author: Remi Collet (remicollet)
Committer: Casper Langemeijer (langemeijer)
Date: 2026-10-14T21:43:34+02:00
Commit: https://github.com/php/pecl-networking-ssh2/commit/89eeb02ab52424e4888d151b14f2aff23f925ac1
Raw diff: https://github.com/php/pecl-networking-ssh2/commit/89eeb02ab52424e4888d151b14f2aff23f925ac1.diff
use zval_ptr_dtor_nogc instead of zval_dtor alias
Changed paths:
M ssh2_fopen_wrappers.c
Diff:
diff --git a/ssh2_fopen_wrappers.c b/ssh2_fopen_wrappers.c
index c654893..a0c4bc9 100644
--- a/ssh2_fopen_wrappers.c
+++ b/ssh2_fopen_wrappers.c
@@ -580,7 +580,7 @@ static php_stream *php_ssh2_shell_open(LIBSSH2_SESSION *session, zend_resource *
if (libssh2_channel_setenv_ex(channel, key->val, key->len, Z_STRVAL(copyval),
Z_STRLEN(copyval))) {
php_error_docref(NULL, E_WARNING, "Failed setting %s=%s on remote end",
ZSTR_VAL(key), Z_STRVAL(copyval));
}
- zval_dtor(©val);
+ zval_ptr_dtor_nogc(©val);
}
} else {
php_error_docref(NULL, E_NOTICE, "Skipping numeric index in environment array");
@@ -854,7 +854,7 @@ static php_stream *php_ssh2_exec_command(LIBSSH2_SESSION *session, zend_resource
if (libssh2_channel_setenv_ex(channel, key->val, key->len, Z_STRVAL(copyval),
Z_STRLEN(copyval))) {
php_error_docref(NULL, E_WARNING, "Failed setting %s=%s on remote end",
ZSTR_VAL(key), Z_STRVAL(copyval));
}
- zval_dtor(©val);
+ zval_ptr_dtor_nogc(©val);
}
} else {
php_error_docref(NULL, E_NOTICE, "Skipping numeric index in environment array");