[pecl-networking-ssh2] master: Fix tests
| From: | Casper Langemeijer | Date: | Fri, 16 Oct 2026 15:32:55 +0000 |
| Subject: | [pecl-networking-ssh2] master: Fix tests | ||
| Groups: | php.pecl.cvs | ||
| Request: | Send a blank email to pecl-cvs+get-28703@lists.php.net to get a copy of this message | ||
Author: Casper Langemeijer (langemeijer)
Date: 2026-10-16T15:57:41+02:00
Commit: https://github.com/php/pecl-networking-ssh2/commit/5cca4eb434245633641ea99ae5ea67616ea8d41b
Raw diff: https://github.com/php/pecl-networking-ssh2/commit/5cca4eb434245633641ea99ae5ea67616ea8d41b.diff
Fix tests
Changed paths:
M tests/ssh2_close_timeout.phpt
M tests/ssh2_connect.phpt
Diff:
diff --git a/tests/ssh2_close_timeout.phpt b/tests/ssh2_close_timeout.phpt
index e8079cb..650c243 100644
--- a/tests/ssh2_close_timeout.phpt
+++ b/tests/ssh2_close_timeout.phpt
@@ -11,7 +11,7 @@ if (!function_exists('ssh2_set_timeout')) {
<?php require('ssh2_test.inc');
$ssh = ssh2_connect(TEST_SSH2_HOSTNAME, TEST_SSH2_PORT);
-ssh2_auth_pubkey_file($ssh, TEST_SSH2_USER, TEST_SSH2_PUB_KEY, TEST_SSH2_PRIV_KEY);
+ssh2t_auth($ssh);
$start = microtime(true);
diff --git a/tests/ssh2_connect.phpt b/tests/ssh2_connect.phpt
index e66e4cf..6165c99 100644
--- a/tests/ssh2_connect.phpt
+++ b/tests/ssh2_connect.phpt
@@ -13,14 +13,12 @@ var_dump(get_resource_type($ssh));
echo "**Fingerprint MD5\n";
$md5 = ssh2_fingerprint($ssh);
var_dump(is_string($md5));
-var_dump(strlen($md5));
-var_dump(ctype_xdigit($md5));
+var_dump(preg_match('(^[\dA-F]{32}$)', $md5) === 1);
echo "**Fingerprint SHA1\n";
$sha1 = ssh2_fingerprint($ssh, SSH2_FINGERPRINT_SHA1 | SSH2_FINGERPRINT_HEX);
var_dump(is_string($sha1));
-var_dump(strlen($sha1));
-var_dump(ctype_xdigit($sha1));
+var_dump(preg_match('(^[\dA-F]{40}$)', $sha1) === 1);
function ssh2t_strset($v) {
return is_string($v) && (strlen($v) > 0);
@@ -42,11 +40,9 @@ bool(true)
string(12) "SSH2 Session"
**Fingerprint MD5
bool(true)
-int(32)
bool(true)
**Fingerprint SHA1
bool(true)
-int(40)
bool(true)
**Negotiation
bool(true)