Re: cvs: pecl /ibm_db2 TODO config.m4 ibm_db2.c php_ibm_db2.h

Dan Scott wrote:

dbs Tue Apr 5 20:17:49 2005 EDT

  Added files:                     /pecl/ibm_db2	ibm_db2.c config.m4 php_ibm_db2.h TODO   Log:

First cut of ibm_db2 extension for IBM DB2/Cloudscape and Apache Derby. ------------------------------------------------------------------------ Hi again,

1) just spotted and in the header file several functions are exported : void _php_check_sql_errors void _php_assign_options int _php_parse_options int _php_db2_foreign_keys_helper(INTERNAL_FUNCTION_PARAMETERS); int _php_db2_column_privileges_helper(INTERNAL_FUNCTION_PARAMETERS); int _php_db2_primary_keys_helper(INTERNAL_FUNCTION_PARAMETERS); int _php_db2_special_columns_helper(INTERNAL_FUNCTION_PARAMETERS); int _php_db2_table_privileges_helper(INTERNAL_FUNCTION_PARAMETERS); int _php_db2_procedure_columns_helper(INTERNAL_FUNCTION_PARAMETERS); I am assuming that these are, and will only be used, only from this extension. If this is the case please remove them from the header file and declare them as static (just move the declaration to the beginning of the C file and add static). Almost every extension makes use of these so called helper functions but they are declared as static not to pollute the global namespace. In this case you can also think about removing the trailing underscore. The names of the first 3 sound to general, it would be nice if you insert "db2" after "php_" in their names. Please also add a prefix DB2_ for the following preprocessor directives : #define MAX_OPTION_LEN 10 #define MAX_ERR_MSG_LEN (SQL_MAX_MESSAGE_LENGTH + SQL_SQLSTATE_SIZE + 1) 2) Is this extension experimental. If yes, please add an empty file named EXPERIMENTAL. A file CREDITS listing the authors of the extension is also appreciated. All the names should appear on one line. Best wishes! Andrey