Re: Addition of php-scrypt to pecl
| From: | Michael Wallner | Date: | Tue, 30 Apr 2013 08:05:48 +0000 |
| Subject: | Re: Addition of php-scrypt to pecl | ||
| References: | 1 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-10578@lists.php.net to get a copy of this message | ||
On 29 April 2013 11:30, Dominic Black <thephenix@gmail.com> wrote:
>
> Current source code is at;
> https://github.com/DomBlack/php-scrypt
>
Just some comments:
- the spl_ce_BadFunctionCallException must not be declared static, but
extern.
- if you depend on extensions like SPL and hash, delcare it with
ZEND_MODULE_DEP
- if a function is not available on a platform, do not even define the
function
- you shall use php_error_docref()
- bundling libraries is discouraged, but not always possible
Everything else looks pretty fine. :)
--
Regards,
Mike