Re: Adding libmaxminddb extension to PECL
| From: | Greg Oschwald | Date: | Fri, 22 Nov 2013 16:38:20 +0000 |
| Subject: | Re: Adding libmaxminddb extension to PECL | ||
| References: | 1 2 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-11324@lists.php.net to get a copy of this message | ||
>
>
> Overall: +1.
>
> A few minor comments, some more for other reviewers who coulddisagree
> with me ;-)
>
Thanks again for all the feedback! I believe I have implemented all of the
suggestions besides making the code C89 compatible.
There are two reasons I did not do this:
1. Currently libmaxminddb is not C89 compatible.
2. When I tried building my extension with the -std=c89/ansi flag, I found
that most of the failure appeared to come the PHP core header files.
The extension does currently build with the -std=gnu89 flag.
Before filling out the account request form, it looks like I need a
sponsoring user. Is there any process for this or does someone just sign
off on it?
Thanks!
Greg