Re: Apply PECL account for a new extension

On Mon, May 5, 2014 at 3:03 PM, Shuhei Tanuma (chobie) <chobieeee@php.net> wrote: > 2014-05-05 17:15 GMT+09:00 Huqiu Liao <liaohuqiu@gmail.com>: > > We use a kind of binary data format to swap data between java and > php: http://binpack.liaohuqiu.net. It is json like, easy to > implement. > The data after encoded is much smaller, and it is very fast. > > Several programming language has binpack library but it's different > from your code. Is it new serialization spec? > > AFAIK, PHP expects C89 style. so you should not use C99. > extension should have phpt. test_binpack.c can't test with make > test > > > Just curious, Why did not use exsisting serialization library? (like > msgpack, thrift, protobuf, avro...) > > -- > PECL development discussion Mailing List (http://pecl.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > did you ever receive a reply from Huqiu? I think that it is just an (unfortunate) coincidence that Shuhei named this format as binpack(based on his github organization and his website it seems that he is the author of the format). Johannes any chance that you could do a quick review on the extension? (sorry to always bother you with these, but you seems to be the only one doing that nowadays) ps: the config.m4 seems to be autogenerated via ext/ext_skel, and lacking the appropriate manual modifications(it uses both --with-binpack and --enable-binpack for example) -- Ferenc Kovács @Tyr43l - http://tyrael.hu