Re: PECL Account Request: jedisct1

Hi, On Thu, Aug 7, 2014 at 2:04 AM, Frank Denis <php@pureftpd.org> wrote: > Requested from: 67.215.89.29 > Username: jedisct1 > Real Name: Frank Denis > Email: php@pureftpd.org (hide address) > Need php.net Account: yes > Purpose: > I&#039;d like to submit add the PHP extension for the Sodium crypto > library to PECL. > > Sponsor: > Pierre Joye > http://comments.gmane.org/gmane.comp.php.pecl.devel/11168 > > To handle: http://pecl.php.net/admin/?acreq=jedisct1 > > More info: > I am the maintainer of the Sodium library as well as the PHP extension, > and a couple other extensions that I&#039;d be glad to contribute to PECL > later on Nice! First of all thanks for adding all crypto_* functions to the Sodium class. I quickly tried your ext and look to the code. The tests failing on debug mode due to not terminating string with \0: http://lxr.php.net/xref/PHP_5_6/Zend/zend_API.h#540 Except that it's nice and useful. Just few suggestion: - use arg info for all functions accepting params (reflection support) - coding style is different than PHP one (spaces instead of tabs) - not sure if this is required for PECL exts as well Cheers Jakub