Re: I want to publish my PHP Extension in PECL

hi, On Fri, Aug 8, 2014 at 5:11 AM, China 陈毓端 <83868008@qq.com> wrote: > hello: > I am yuduan Chen, I come from Beijing, China. I am a PHP developer, I use PHP for nearly 8 > years. Several years of reading PHP code to the kernel. Process in the company also writes about PHP > extension in c language. Now I have decided to contribute an extension of me, now my main job was to > construct a Hadoop-based data storage, analysis. Used to store with the Java language and Hadoop. > Later in order to easy, I have developed phdfs. I want to phdfs can join the PECL extensions. > phdfs - PHP extensions, using PHP to manipulate Hadoop HDFS,Extension is an interface to HDFS > > > github code address: > https://github.com/yuduanchen/phdfs‍‍ Good idea :) Some comments, in no particular order: - a temp file has been commited, README.md~ - run-tests.php is not needed, it is part of the php development files, whether you install it via your favorite packages or from source - a package.xml is still required to release under pecl - you can give it a try using pickle too, see https://github.com/FriendsOfPHP/pickle - version should be in the x.y.z format, also 1.0.0 for the 1st version is not so good, begin with 0.1.0 f.e. - A CREDITS file is also required I did not try it yet but did not notice any bad things at a first glance. You may like the idea to implement a stream wrapper, could be very handy. I do not see anything preventing you to release it under PECL. It is actually a requirement for you as you used the PHP License. The src repository can remain in github. Cheers, -- Pierre @pierrejoye | http://www.libgd.org