Re: Publishing my PHP extension to PECL
| From: | Boro Sitnikovski | Date: | Tue, 09 Sep 2014 00:44:04 +0000 |
| Subject: | Re: Publishing my PHP extension to PECL | ||
| References: | 1 2 3 4 5 6 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-12261@lists.php.net to get a copy of this message | ||
Hey Johannes,
Cheers! :)
Please let me know how this looks to you: https://github.com/bor0/xmp/commit/c1d359929161411d38c1bc906477098126cbda55
Best regards,
Boro Sitnikovski
On Tuesday, September 9, 2014 1:25 AM, Johannes Schlüter <johannes@php.net> wrote:
On Mon, 2014-09-08 at 16:12 -0700, Boro Sitnikovski wrote:
> However, about the other remark, xmp_create_context() can return NULL
> in case of alloc failure, as shown here
>
> http://fossies.org/dox/libxmp-4.2.8/control_8c_source.html#l00036
> (it
> seems to not be documented).
Alright! I had just a quick look on the code and docs and it looked
suspicious. With xmp_context already being a pointer you eventually
might directly put that pointer into the resource and safe the extra
allocation ... but I didn't look closer.
johannes
--
PECL development discussion Mailing List (http://pecl.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php