Re: [ANNOUNCEMENT] xmldiff-1.1.0 (stable) Released.
| From: | Jan Ehrhardt | Date: | Sun, 01 Feb 2015 23:42:20 +0000 |
| Subject: | Re: [ANNOUNCEMENT] xmldiff-1.1.0 (stable) Released. | ||
| References: | 1 2 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-12563@lists.php.net to get a copy of this message | ||
Jan Ehrhardt in php.pecl.dev (Sun, 01 Feb 2015 23:38:00 +0100):
>"PECL Announce" in php.pecl.dev (1 Feb 2015 20:13:00 -0000):
>>- PHP7 compatibility
>
>To make this compile with PHP7 I had to add __STDC_CONSTANT_MACROS in
>php_xmldiff.h
>
> #define __STDC_LIMIT_MACROS 1
>+#define __STDC_CONSTANT_MACROS 1
>
> #include "php.h"
> #include "php_ini.h"
>
>Otherwise I am getting all undefined errors for INT32_C, UINT64_C and
>the like.
Ok, I see you were getting the same errors on x86:
http://windows.php.net/downloads/pecl/snaps/xmldiff/1.1.0/logs/php_xmldiff-1.1.0-7.0-nts-vc11-x86-logs.zip
Just wondering: if any ext (for instance dom or xml) loads php_stdint.h
before xmldiff, but without setting __STDC_CONSTANT_MACROS, INT32_C will
not be defined.
At the moment the compiler starts with xmldiff, PHP_STDINT_H will
already be defined and main/php_stdint.h will not load
win32/php_stdint.h once again. So INT32_C will remain undefined.
Wouldn't it be better to include win32/php_stdint.h directly in
php_xmldiff.h if you are compiling for Windows?
Jan