Re: Pecl account for Imagick

> On 15 03 2015, at 14:39, Dan Ackroyd <danack@basereality.com> wrote: > > On 12 March 2015 at 06:55, Michael Wallner <mike@php.net> wrote: > >> Awesome, I'd really like to see this extension being kept maintained! > > I've actually been maintaining it for a while. It's just that Mikko > hasn't transferred the source to point to his Github repo > https://github.com/mkoppanen/imagick/ and I've been > prevaricating > about doing an actual release. > > >> Do you have any specific questions? > > Two questions so far: > > i) Where does the version need to be set. The places I'm aware of are > in the header file php_imagick.h > > #define PHP_IMAGICK_VERSION “3.3.0RC1" Yes, this is usually used in the module struct, and the pecl website checks for that version string, too. > #define PHP_IMAGICK_EXTNUM 30300 This is specific to this extension. > > And in the package file: > > <version> > <release>3.3.0RC1</release> Yup. > <api>3.3.0</api> > </version> > > Are there any other places where it needs to be set? Nope, that should be it. > > ii) What should be in the notes field in package.xml? Currently it's set to: > > <notes> > - Fix bug #66098: Segfault in zval_addref_p > </notes> > > Which doesn't seem to be that useful. Oh, they should be. The change logs of the current release go there. They’ll be recorded by the pecl website. See e.g. here: http://pecl.php.net/package-changelog.php?package=pecl_http <http://pecl.php.net/package-changelog.php?package=pecl_http> Regards, Mike