Re: Uploadprogress extension with PHP7 support

Ángel González in php.pecl.dev (Mon, 16 Mar 2015 00:23:29 +0100): >On 15/03/15 23:52, Jan Ehrhardt wrote: >> I added PHP7 support to the uploadprogress extension: >> https://github.com/Jan-E/uploadprogress >> >> Most important commit: >> >> https://github.com/Jan-E/uploadprogress/commit/50d4a16be3fcf4ef8909f4a4785d1416c4de81fe >> Look for the changes with '#if defined(ZEND_ENGINE_3)'. >> >> Under VC11 x86 it only issues one warning. >> warning C4715: 'uploadprogress_php_rfc1867_file' : not all control paths >> return a value >That should be simple to fix: Add a return statement at the end of >uploadprogress_php_rfc1867_file() The warning must have been there for ages. I'd rather not muddle with that unless anybody has a clear opinion on what should be returned. There are a number of 'return 0' statements inside uploadprogress_php_rfc1867_file(). I could add something like 'return SUCCESS' at the end of the function, but maybe it is better to leave the function the way it has always been. Jan