Re: New pecl project

Hi, On Wed, 2015-04-08 at 04:08 -0400, Cesar Rodas wrote: > I'm working on a project to embed duktape (Javascript) engine inside > PHP. What are the requirements to host the project on pecl? The requirement is to write a mail as you did and hope somebody reviews it ;-) A few review comments: 1. Please add a license header, especially as the repo mixes code from different origin (duktape and your code) 2. Please add /* {{{ proto */ comments to exported functions, this helps documentation tools 3. Please don't use zend_error, see https://wiki.php.net/internals/review_comments#don_t_use_zend_error 4. E_ERROR typically is a bad choice, should only be used when you really can't recover, maybe E_RECOVERABLE or an exception are better 5. Provide a php_phpjs.h header (this is needed for static builds, which probably nobody will do, but is common style, see https://wiki.php.net/internals/review_comments#php_extnameh_should_be_minimal) 6. We prefer a coding style where even single line if's etc. have {} (helps to prevent bugs like Apple's goto fail;) While we're not strict about this All minor things, but I also didn't do an in-depth review ;-) If those are fixed seems ok to me. johannes

Attachment: [application/pgp-signature] This is a digitally signed message part signature.asc