RE: [PECL-DEV] Introduction: Szabi, extension: memcache
| From: | Anatol Belski | Date: | Tue, 10 Nov 2015 12:45:51 +0000 |
| Subject: | RE: [PECL-DEV] Introduction: Szabi, extension: memcache | ||
| References: | 1 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-13308@lists.php.net to get a copy of this message | ||
Hi Szabolcs,
> -----Original Message-----
> From: Szabolcs Balogh [mailto:baloghsz@szabi.org]
> Sent: Tuesday, November 10, 2015 1:04 PM
> To: pecl-dev@lists.php.net
> Subject: [PECL-DEV] Introduction: Szabi, extension: memcache
>
> Hi
>
> I'm writing there because of
> https://pecl.php.net/account-request.php.
>
> My name is Szabolcs Balogh(Szabi), working in a webhosting company, and
> coding.
>
> I ported memcache extension to php7 in last weeks, code at:
> https://github.com/websupport-sk/pecl-
> memcache/commit/005a35cde8439a053632047eb28e59fcc8cb7ea2
> bug-report at:
> https://bugs.php.net/bug.php?id=70751
>
> So i want to help with this extension.
>
Great start!
Just quick issue summary in your patch, UPGRADING INTERNALS contains the most information as well as
the PHPNG wiki
- ZPP 'l' format requires zend_long
- ZPP 's' format requires size_t
- ZEND_STRTOL is required (together with zend_long) instead of strtol (particularly for INI)
- TSRM_* macros can be removed, and please specifically see the TSRM section in UPGRADING.INTERNALS
You probably can spot some issues with 64-bit Linux/Windows builds.
Thanks
Anatol