RE: [PECL-DEV] VCS Account Request: matkins

Hi, Thanks for your porting work. Some issues I've seen so far: - no sense to rename all the stuff, the package name is printer, not printer7 - TSRMLS_* macros are not required - TS support is not implemented - printer7.c:1714 - new_value is zend_string - some places are not C89 compatible, we still stick to it. Many other points about coding style are here http://git.php.net/?p=php-src.git;a=blob_plain;f=CODING_STANDARDS;hb=HEAD (fe the way preprocessor defines are indented) If you're intended to maintain this ext, I'd be really nice. I was asking to take over this package some time ago, but somehow it didn't work and I had no time afterwards, anyway. IMHO it is feasible to add you to the printer PECL package, so you can commit to the repo and release. I might supply some patches as well to get the ext more robust. Thanks Anatol > -----Original Message----- > From: Marl Atkins [mailto:peclcoder@softlinksys.com] > Sent: Wednesday, July 20, 2016 8:41 PM > To: pecl-dev@lists.php.net > Subject: [PECL-DEV] VCS Account Request: matkins > > I want to add an extension to PECL. > You have an outdated extension: > php_printer.dll. > > I've updated this extension to work with phpng, the newer printers > and newer Windows operating systems. > I renamed it: php_printer7.dll > > I added functionality to list paper bins, paper sizes, fonts and resolutions for a > given printer. > > I made setting options (ie copies, orientation, paper size, paper tray(newly > added)) work. > > I made printer_draw_text work and tested it. I did update the other draw > functions but did not test them. > > I've tested it in Windows 10 and Windows Server 2012 R2. > > I'd like to add this extension to the PECL library and open it to the > pecl development community to add, fix, etc. > > > https://www.dropbox.com/sh/kyqr5fujjmoc5c3/AABlSqJIBczTWJHqIDjbvHhta?dl > =0 > > Sponsor: > I have received no responses from the pecl-dev@lists.php.net mailing list as of > yet. > > > -- > PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, > visit: http://www.php.net/unsub.php