Re: New extension proposal (geohash)

Le 07/09/2017 à 23:43, Emir Beganović a écrit : > Hi, > > I'd like to propose a new extension named geohash, that brings geohash > encoding and decoding functionality. There is a significant performance > gain from using this extension compared to user-land libraries. > > The extension is licensed under the BSD licence. > > I would like to submit the geohash extension into the PECL directory. > Source code is available at > https://github.com/emirb/php-geohash-ext > > Best, > Emir Beganovic > Please fix License headers LICENSE.md states BSD-2 (md suffix have no value here) php_geohash.c: have "PHP license" header geohash.c: license header is missing Various type mismatch in zpp calls l => must be a zend_long in 7.x s => must be a size_t in 7.x, int in 5.x Uneeded, excepted if you want to support 4.x ;) #if ZEND_MODULE_API_NO >= 20010901 Common practice it to use a 3 digits value and follow semver #define PHP_GEOHASH_VERSION "1.0" In PHP_FUNCTION(geohash_encode) efree should only call for 7.x (as in 5.x you don't copy the buffer) A few tests will be welcome ;) Remi

Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc