Re: Publish wkhtmltox extension to PECL

Morning Johannes, Have switched that to RINIT, thanks for that info. I wasn't aware of the concurrency issues. Still, restricting the build seems unnecessary. You may load the extension in a zts build of php, but not actually be using any threads - you aren't going to be loading it inside apache worker is my suspicion. I already created the package on pecl, but we are not sure if it's allowed or not, because of licensing issues. Cheers Joe On Sat, Nov 11, 2017 at 3:15 PM, Johannes Schlüter <johannes@schlueters.de> wrote: > On Sa, 2017-11-11 at 11:47 +0100, Remi Collet wrote: > > Joe have a new extension > > https://github.com/krakjoe/wkhtmltox > > > > This extension wraps libwkhtmltox for PHP 7. > > Two quick comments on this: > > In RINIT this starts up a QApplication context (via wkhtmltopdf_init) > for each request, even if the functionality is not used. Either this > should be delayed till first request to the extension is being made or > this should be done in MINIT (might be problematic with forking SAPI > environments) > > Secondly: The wkhtml library uses global state in non-thread-safe > manner it seems. (only spent 5 minutes on this in total ...) config.m4 > should disallow building in threaded context. > > > > I will take care of the release process > > > > Can you please create the project, so I can upload it ? > > I would assume you have the power yourself, can you try? Try via > https://pecl.php.net/package-new.php > > johannes >