Re: Publish stackdriver_debugger extension to PECL

Hi, I took a quick look and didn't find any real issue. Two very minor comments: * In the PHP_FUNCTIONs our policy is to do a simple "return;" which keeps the return value as NULL in case parameter parsing fails. You are doing RETUN_FALSE.  * You state Copyright Google Inc, in other places I see it referred as Google LLC these days ... I assume you know better than me as an outsider, though :-) So I think it's fine to register the packag via https://pecl.php.net/pa ckage-new.php johannes On Mo, 2017-11-13 at 19:16 +0000, Jeff Ching wrote: > Hi pecl-dev, > > We've created a new extension > > https://github.com/GoogleCloudPlatform/stackdriver-debugger-php-exten > sion > for Stackdriver Debugger (https://cloud.google.com/debugger/) which > is a > way to inspect the state of your running (production!) application > with > requiring a restart or slowing down your app. You are able to capture > local > variable state and add logging statements. > > This product is also available for Java, Go, Python, Ruby, and > NodeJS. It > is free to use for all Google Cloud Platform customers and will run > wherever you can set it up. > > The extension takes care of capturing snapshots of data or injecting > log > statements by modifying the AST during compilation. By beta, we will > be > ensuring that we don't spend more than 10ms to latency or 10MB of > memory to > the process. There will be a PHP space library accompanying it as > google/cloud-debugger ( > https://github.com/GoogleCloudPlatform/google-cloud-php but > currently > in a > fork/PR here: > > https://github.com/GoogleCloudPlatform/google-cloud-php/pull/716). > The PHP > component handles fetching the list of breakpoints/logpoints from the > backend server. > > We'd like to make this extension available via PECL. > > Any comments are greatly appreciated. > > Thanks, > > Jeff Ching