Re: New extension proposal: rpminfo
| From: | Johannes Schlüter | Date: | Fri, 26 Jan 2018 16:18:45 +0000 |
| Subject: | Re: New extension proposal: rpminfo | ||
| References: | 1 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-15083@lists.php.net to get a copy of this message | ||
Hi,
On Fr, 2018-01-26 at 15:05 +0100, Remi Collet wrote:
>
> Sources available at
> https://git.remirepo.net/cgit/tools/php-rpminfo.git/tree/
Fro a quick look the only comment I hav is that I'd take the RPMINFO_G
elated stuff out of the header and move it to .c, but that's a bit of
subjective taste.
An idea might be to return an error code instead of just printing the
error message ... bu not sure that's of practical use. A broken file is
a broken file and a PHP script couldn't recover anyways.
johannes