Re: clusterize extension
| From: | Ivan Pomortsev | Date: | Sat, 19 May 2018 16:05:55 +0000 |
| Subject: | Re: clusterize extension | ||
| References: | 1 2 3 4 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-15330@lists.php.net to get a copy of this message | ||
Hi Anatol,
Thank you again for feedback
For nNumOfElements there's also an API as zend_hash_num_elements(). In
> general, it is better to use APIs as they hide implementation details which
> might change at some point while APIs are more likely to be kept compatible.
I changed that parts to using of zend_hash_num_elements() function. I agree
with your point about compatibility
If a file has been bundled and its license allows it, so it could be
> patched. One can carry the patch within the extension, if needed, in case
> the bundled file needs to be updated, etc. In this exact case, the
> advantages of emalloc vs. malloc and et cetera is, that ZMM is used with
> better performance and correct memory usage calculation.
OK, I see.
Cool, thanks for checking the notes. It's now to see for perhaps more
> comment and otherwise PECL admins to accept your request.
>
OK, I'll wait for one more week and then, if there'll be no more comments,
I'll register an account at pecl.php.net and propose that extension.
Ivan