Re: Bug #79627 [PATCH]: Fixes for 7.3/7.4 and Opcache

Hey Mike, some of these patches look like they justify a new release now. What do you think? > On May 25, 2020, at 4:33 AM, JJ <johnjawed@gmail.com> wrote: > > Hey Mike - thanks, I’ll spend some time on this today. > >> On May 25, 2020, at 12:42 AM, mike@php.net <pecl-dev@lists.php.net> wrote: >> >> Edit report at >> https://bugs.php.net/bug.php?id=79627&edit=1 >> >> ID: 79627 >> Patch added by: mike@php.net >> Reported by: mike@php.net >> Summary: Fixes for 7.3/7.4 and Opcache >> Status: Open >> Type: Bug >> Package: oauth >> PHP Version: 7.4.6 >> Block user comment: N >> Private report: N >> >> New Comment: >> >> The following pull request has been associated: >> >> Patch Name: Fixes for 7.3/7.4 and opcache >> On GitHub: https://github.com/php/pecl-web_services-oauth/pull/14Ý >> m´ïùù7ćÆôñá >> Patch: >> https://github.com/php/pecl-web_services-oauth/pull/14.patch >> >> >> Previous Comments: >> ------------------------------------------------------------------------ >> [2020-05-25 07:42:16] mike@php.net >> >> Description: >> ------------ >> * Fix PHP-7.4 compatibility of object handler >> * Fix memory leaks in OAuthProvider >> * Fix crash in OAuthProvider's handler registration methods due to unconditional >> addref >> * Fix crash in OAuth::fetch() due to modifying hash tables with a refcount>1 >> >> >> >> >> ------------------------------------------------------------------------ >> >> >> >> -- >> Edit this bug report at >> https://bugs.php.net/bug.php?id=79627&edit=1