Bug #80850 [Asn->Csd]: Missing LuaSandbox DLLs on PECL

Edit report at https://bugs.php.net/bug.php?id=80850&edit=1 ID: 80850 Updated by: cmb@php.net Reported by: cmb@php.net Summary: Missing LuaSandbox DLLs on PECL -Status: Assigned +Status: Closed Type: Bug Package: PECL Operating System: Windows PHP Version: 7.4.16 Assigned To: tstarling Block user comment: N Private report: N New Comment: Ah, right! Previous Comments: ------------------------------------------------------------------------ [2021-05-19 07:20:06] legoktm at member dot fsf dot org Per <https://windows.php.net/downloads/pecl/releases/luasandbox/4.0.2/> this is fixed now! I don't believe I have permissions to close this bug though if someone could do that. ------------------------------------------------------------------------ [2021-03-10 18:00:15] cmb@php.net > The config.w32 omission is accidental, I'll get that fixed for > the next release. Thanks! > Is it possible to add Lua 5.1 to the list of Windows > dependencies? Yes, I'll do that ASAP. ------------------------------------------------------------------------ [2021-03-10 16:34:24] legoktm at member dot fsf dot org The config.w32 omission is accidental, I'll get that fixed for the next release. However, LuaSandbox is specific to Lua 5.1, so 5.3 won't work. <https://phabricator.wikimedia.org/T178146> goes into more detail about this. Is it possible to add Lua 5.1 to the list of Windows dependencies? ------------------------------------------------------------------------ [2021-03-10 10:53:37] cmb@php.net Description: ------------ Obviously, there are no LuaSandbox DLLs available for download on PECL. The primary reason is that config.w32 is missing in the packages, although it exists in the repo[1]. If the missing config.w32 is just an oversight, please add it. If it gets added, the next issue would be the check for lua5.1.lib, which appears to be overly restricted. There are lua packages available for PECL builds[2], but these have lua 5.3.4, and the library is named liblua.lib. It would be good to add at least a fallback for that name, i.e. something like CHECK_LIB("lua5.1.lib;liblua.lib", "luasandbox", PHP_LUASANDBOX) [1] <https://phabricator.wikimedia.org/diffusion/MLUS/browse/master/config.w32> [2] <https://windows.php.net/downloads/pecl/deps/> ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=80850&edit=1