[oci] lob_read & malloc

php_oci_lob_read emallocs blocs of PHP_OCI_LOB_BUFFER_SIZE (1Mo) : *data = emalloc(block_length + 1); Wouldn't it be more efficient to allocs to the right size ? --- oci8_lob.c 2005-09-06 23:42:26.000000000 +0200 +++ oci8_lob-new.c 2005-10-19 16:46:44.000000000 +0200 @@ -192,7 +192,7 @@ } } - *data = emalloc(block_length + 1); + *data = emalloc(length + 1); bytes_read = block_length; while (bytes_read > 0 && *data_len < requested_len && offset < length) { @@ -219,7 +219,7 @@ descriptor->lob_current_position += bytes_read; if (*data_len < requested_len && connection->errcode == OCI_NEED_DATA) { - *data = erealloc(*data, *data_len + PHP_OCI_LOB_BUFFER_SIZE + 1); + //*data = erealloc(*data, *data_len + PHP_OCI_LOB_BUFFER_SIZE + 1); continue; } else { break; Jean-François Bustarret eTF1 - Architecte ------------------------------------- Le present message (y compris tous les elements attaches) est confidentiel et est destine a ses seuls destinataires. Si vous l'avez recu par erreur, merci de l'indiquer a son expediteur par retour et de proceder a sa destruction dans vos systemes. Toute utilisation ou diffusion non autorisee de son contenu, en totalite ou en partie, est strictement interdite. Les idees et opinions presentees dans ce message sont celles de son auteur, et ne representent pas necessairement celles de TF1 (et/ou des entites membres du Groupe TF1). This message (including any attachments) is confidential and may be privileged. If you have received it by mistake please notify the sender by return email and delete this message from your system. Any unauthorised use or dissemination of this message in whole or in part is strictly prohibited. Any views or opinions presented are solely those of its author and do not necessarily represent those of TF1 (and/or its group companies).