Re: Re: [PATCH] Extending subversion module

Thanks, just commited it. can you do a clean cvs checkout, and double check everything works (I've not had time to do that here.) Regards Alan Luca Furini wrote:

I'm attaching the patch that makes the package use again normal php streams instead of custom resources. This also makes a few methods I added (svn_stream_*) completely useless, as the returned streams can be handled using the php functions (stream_get_contents(), stream_copy_to_stream(), ....). I'm successfully testing the modified package, adding, deleting and modifying large binary files in a repository. (hope this message arrives, I still can't see my previous one ...) Regards

    Luca

- struct php_svn_stream *stream = NULL; - svn_error_t *err; - - if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "r", - &zstream)) { - return; - } - - ZEND_FETCH_RESOURCE(stream, struct php_svn_stream *, &zstream, -1, "svn-stream", le_svn_stream); - - err = svn_stream_close(stream->stream); - - if (err) { - php_svn_handle_error(err TSRMLS_CC); - } -} -/* }}} */ - /* * Local variables: * tab-width: 4