Re: new extension txforward

Looked at code. The idea is clear — I guess it is ok, as initial commit. some comments: 1) compiler gives warning: txforward-1.02/txforward.c: In function 'zm_activate_txforward': txforward-1.02/txforward.c:94: warning: passing argument 1 of '_zval_copy_ctor' from incompatible pointer type zval_copy_ctop expects *zval, but you give it **zval 2) code-formatting is a little-bit messed (spaces instead of tabs on line 73, 2 expressions on line 70) On Fri, Jun 27, 2008 at 1:22 AM, Francois Cartegnie <k0eh06usjokthn1@jetable.net> wrote: > Le jeudi 26 juin 2008, vous avez écrit : >> The next steps are: >> >> - show some code (link to the sources and licenses) > Well the current package is there: > http://fcartegnie.free.fr/patchs/txforward.html > Licence, i don't know. PECL says to link it to PHP licence 3.0. > > There's not much code to review, as this is a really simple hack. > People needs to modify php code when behind reverse proxy, which tends to be a > problem when you have multiple customers on the same server. > > The only case I would point is when this would be running on a web server > without proxy, and the remote peers fakes an X-Forwarded header with a string > finishing with a period, the ip would copy one byte of data (the > variable .len) into ip address. > Anyway, the erroneous ip results of a misconfiguration and so results existing > security hole. > > -- > PECL development discussion Mailing List (http://pecl.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Alexey Zakhlestin http://blog.milkfarmsoft.com/