Re: bcompiler

Antony Dovgal wrote:

On 09.08.2008 11:10, Daniel Henning wrote:

Hi, i've contacted both longer ago (serveral times). Maybe I got caught by some spamfilters. Someone with carma may could submit these patches. For me it works stable in the way I'm using it. (compiling everything with bcompiler_write_file, compiling template-datastructures at runtime and so on).

I can commit it, but I need a confirmation from someone who knows bcompiler better than I do.

Hi all, back from vacation. Firstly the patch has a nasty bug I haven't cached the first time. Around line 12 (or 34 if you look at the second patch) you have this: + BCOMPILERG(currentfile) = NULL; + efree(BCOMPILERG(currentfile)); I got nasty segfaults because of it and unless programming and execution changed over night... I also looked at the first patch, didn't test it with PHP 5.3 yet. Secondly, I started writing phpt files for bcompiler as none exist yet... I do a have a question about it that I'm unable to answer myself: I have a bcompiler_001.phpt that takes an external file bcompiler_001.inc, bcompiles is and include()s it for execution. But this way the code that is being tested is actually in an external file. Is there any way to beautify this storage? Insert the code into .phpt file and somehow get it out in the process of the test? I'll be able to post the tests dir soon. Any suggestions how, I'm new to this list, not sure how things are done. Thanks, Damjan