Re: Re: Extension proposition: proctitle
| From: | Mark Karpeles | Date: | Fri, 23 Jan 2009 13:06:37 +0000 |
| Subject: | Re: Re: Extension proposition: proctitle | ||
| References: | 1 2 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-6080@lists.php.net to get a copy of this message | ||
Le vendredi 23 janvier 2009 à 12:30 +0100, Johannes Schlüter a écrit :
> Hi,
> A few minor comments, but in general a +1:
> a)
> instead of
> symbol = (sapi_module_struct *)dlsym(NULL, "sapi_module");
> won't a simple
> symbol = &sapi_module;
> do? sapi_module is exported as a global from SAPI.h.
Indeed, that was from some merged code, but it compiles nicely without
using dlsym() (and is better, as lookup is done as compile time when
creating the reloc tables instead of runtime).
B and C also fixed in svn.
> As said all minor cosmetic stuff.
Ok, well if anyone else has any feedback, I'll be happy to fix things
you may see. If the package is accepted I'll add package.xml and a few
other files (changelog? readme? authors?)
Mark