Re: LibTextCat wrapper
| From: | Alexey Zakhlestin | Date: | Sun, 29 Mar 2009 07:19:01 +0000 |
| Subject: | Re: LibTextCat wrapper | ||
| References: | 1 2 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-6269@lists.php.net to get a copy of this message | ||
Hi, Cesar.
It looks perfectly good, actually.
The only thing which could be would be nice to change:
Currently, you use procedural API with resources. I would chose OOP
api (create object instead of resource and call it's methods instead
of passing resource as explicit parameter)
I think that you are ready to request CVS and PECL accounts.
p.s. for those who didn't go to links: library is BSD licensed,
extension is PHP licensed
On Sun, Mar 29, 2009 at 10:24 AM, Cesar D. Rodas <saddor@gmail.com> wrote:
> From sometime I played with the LibTextCat
> (http://software.wise-guys.nl/libtextcat/) and I wrote some PHP code
> (right now closed source at www.languess.com). So I started writing a
> native extension that will wrap this libtextcat, to improve its
> performance.
>
> Right it's missing a lot of things, add warning messages, throw
> exceptions, and add functions to configure how it would work
> (threshold, limits in return, use the NGram functions itself, and so
> forth). As this very very alpha, it is missing comments on text, and
> the PHP styling code, I will fix it in the weekend.
>
> I'd like to get some feedback if I am doing something bad, or If I am
> missing something.
>
> The temporary repo it's
> http://github.com/crodas/phplibtextcat/tree/master
--
Alexey Zakhlestin
http://www.milkfarmsoft.com/