RE: [PECL-BUG] Bug #16969 [Com]: Possible crash in error recovery

Attaching the patch for review. I will commit the changes once the review is done. This is part of bugger change. I am trying to get rid of local cache. So please bear this small patch. Thanks, Don. -----Original Message----- From: don dot raman at microsoft dot com [mailto:pecl-dev@lists.php.net] Sent: Sunday, December 13, 2009 4:30 PM To: Ruslan Yakushev; Venkat Raman Don; Kanwaljeet Singla (IIS); pierre.php@gmail.com Subject: [PECL-BUG] Bug #16969 [Com]: Possible crash in error recovery Edit report at http://pecl.php.net/bugs/bug.php?id=16969&edit=1 ID: 16969 Comment by: don dot raman at microsoft dot com Reported By: donraman at php dot net Status: Open Id: 16969 Type: Bug Package: WinCache Operating System: Windows PHP Version: 5.2.11 New Comment: The problem is happening because in the function PHP_MINIT_FUNCTION inside file php_wincache.c we also need to set these two lines so that value sets to NULL. WCG(lfcache) = NULL; WCG(locache) = NULL; If we do not set it to NULL, it will get deleted again in PHP_MSHUTDOWN_FUNCTION. Previous Comments: ------------------------------------------------------------------------ [2009-12-13 19:20:09] donraman at php dot net Description: ------------ If for some reason the function PHP_MINIT_FUNCTION in the file php_wincache.c fails, WINCACHE crashes in the PHP_MSHUTDOWN_FUNCTION function. Reproduce code: --------------- There is no code to reproduce. I just changed the PHP_MINIT_FUNCTION to force an error. Recompile the WINCACHE code and use any small PHP file like the one below: <?php echo 'My name is Don'; ?> A crash can be seen. Expected result: ---------------- The code should handle failure in WINCACHE and exit gracefully. Actual result: -------------- An access violation. ------------------------------------------------------------------------ -- Edit this bug report at http://pecl.php.net/bugs/bug.php?id=16969&edit=1