Re: new rrd tool extension
| From: | Miroslav Kubelík - seznam | Date: | Tue, 11 May 2010 08:19:31 +0000 |
| Subject: | Re: new rrd tool extension | ||
| References: | 1 2 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-7217@lists.php.net to get a copy of this message | ||
On Mon, 10 May 2010 19:27:38 +0200, Johannes Schlüter <johannes@schlueters.de> wrote:
Quick review looks fine, a few small comments though:
* rrdtool uses GPL with FLOSS Exception. Exception is valid for
PHp License 3.0, not the current version 3.01, could you talk to
the rrdtool maintainers to add version 3.01?
OK, I'll try.
* in rrd.c you're using C99/C++ comments, please use always /* */
instead of //.
....