Re: --enable-ext VS --with-ext

Thanks Rasmus. I see that the config.m4 file in amfext uses --with-amf but it only references the following includes: #include "php.h" 23 #include "ext/standard/php_string.h" 24 #include "ext/standard/php_var.h" 25 #include "ext/standard/php_smart_str.h" 26 #include "ext/standard/basic_functions.h" 27 #include "ext/standard/php_incomplete_class.h" 28 #include "php_amf.h" 29 #include "php_memory_streams.h" 30 #include "ext/standard/info.h" 31 #include "stdlib.h" None of these look particularly "external" to me. On the other hand, AMFEXT may not be the paragon of PECL style. On Wed, Aug 4, 2010 at 10:35 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote: > Things that require a 3rd-party library use --with.  Extension like json > and exif that include the entire implementations of exif and json > handling in them would use --enable, but extension like mysql and oci > that need the client libraries to do the actual work use --with. > > -Rasmus > > On 8/4/10 10:22 AM, j adams wrote: >> I'm reading the comments in the config.m4 generated by ext_skel and trying >> to understand under what circumstances one would use --enable-ext and when >> one would use --with-ext. >> >> What constitutes "something external" ? >> >> >> >> >> dnl If your extension references something external, use with: >> >> dnl PHP_ARG_WITH(fmog, for fmog support, >> dnl Make sure that the comment is aligned: >> dnl [  --with-fmog             Include fmog support]) >> >> dnl Otherwise use enable: >> >> dnl PHP_ARG_ENABLE(fmog, whether to enable fmog support, >> dnl Make sure that the comment is aligned: >> dnl [  --enable-fmog           Enable fmog support]) >> > >