AMFEXT patch
| From: | J. Adams | Date: | Fri, 01 Oct 2010 22:00:49 +0000 |
| Subject: | AMFEXT patch | ||
| Groups: | php.pecl.dev | ||
| Request: | Send a blank email to pecl-dev+get-7707@lists.php.net to get a copy of this message | ||
I know this is hardly much of a fix, but it at least compiles on windows
and OSX. Attached please find my first patch for AMFEXT. I'll try
checking it into SVN in a bit.
I have successfully compiled it on my Win XP desktop using SDK 6.1 and
32-bit compilers and I have also compiled it successfully on OSX 10.5.
It reflects some changes I've made as well as some contributions [which
I don't fully understand] from a guy named Mikko on irc:#php.pecl. I
have attached an svn diff patch to this email.
The changes include the following
1) Changed references to ZVAL_ADDREF, ZVAL_DELREF, and ZVAL_REFCOUNT to
Z_ADDREF, Z_DELREF and Z_REFCOUNT, respectively per Gustavo Lopes'
sagacious instruction. Added conditional declarations of the new macros
per Michael Maclean's generous suggestion. This is what permits
compilation in my WinXP environment.
2) Added REGISTER_LONG_CONSTANT declarations to PHP_MINIT_FUNCTION so
that these flag constants are available within PHP. I reckon there
should be more added but am not sure which yet.
3) Changes made by Mikko to remove reference to zend_get_parameters_ex
in favor of zend_parse_parameters. There are still 6 instances of the
older funtion which I'd like to work on but I'll need some time to
understand exactly what's going on in the code.
4) Re-ordering of code so that constant declarations precede MINIT
function in which they are used.
Sorry for the delay. I took a trip to the hospital last week. AMFEXT
still has a variety of problems but this is a start.