Re: Re: php_yaf a PHP framework extension

+ mail list Best regards 惠新宸 Xinchen Hui http://www.laruence.com/ -------- Original Message -------- Subject: Re: [PECL-DEV] Re: php_yaf a PHP framework extension Date: Thu, 14 Oct 2010 18:02:05 +0800 From: 惠新宸 <huixinchen@baidu.com> To: mike@php.net Hi: yaf is my first "OO" extension , there are many shortcomings, I will make it more perfect.. 1 & 2, I am working on(I am trying compile yaf under win32/vs2008). why not use singleton is I don't want the use access Yaf_Application instance directly. register list destruct was deleted already. register logo can be deleted. and I will fixed all the problems your mentioned. thank you so much, your suggestions is very helpful. more suggestions? Best regards 惠新宸 Xinchen Hui http://www.laruence.com/ On 10/14/2010 14:48, Michael Wallner wrote:

On 10/13/2010 08:15 AM, 惠新宸 wrote:

Hi: any feedback is appreciated

Some suggestions while reading through the code: - your code is not C89 compatible (variable decls) - and I guess it's not C++ compiler compatible (use of "this") - is there really any need to preface non-public members with underscores? - Yaf::__construct() sets/reads YAF_G(instance)

    Why not use the singleton pattern and a static Yaf::$instance property?

- yaf_config_instance calls PHP_FUNCTION(parse_ini_file)

    Why don't you directly call zend_parse_ini_file()?

- Yaf_Controller::redirect enforces 302 response code

    Why not let PHP figure out which code to use best?

- Why do you register all those list destructors? - registering a logo is a bit... So far, Mike -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php