Re: New package: discount

hi, On Sat, Jan 8, 2011 at 9:20 AM, Gustavo Lopes <glopes@nebm.ist.utl.pt> wrote: > In any case, the current markdown package is still based on discount. > > Modesty aside, mine is fairly superior: Thanks to make me smile :) > * The current markdown package relies on ZEND_ACC_ALLOW_STATIC, which is > deprecated (BC only, as the comment on zend_compile.h puts it) and raises an > E_STRICT. Irrelevant, one liner. > * It has a constructor that takes a required flags parameter, which despite > being required may or may not be used, depending on how you call the > instance functions. Nothing bad here. > * It exposes only the most basic discount interfaces (no url or attributes > callback, no mkd_line, and no interface for mkd_css and mkd_toc if I > recall). Those were not available by the time I wrote the binding. > * Misses some discount flags Same. > * It hasn't been updated for two years. It works very well in 3 projects and the underlying library did not get significant update in Q1/2010 to justify updates, nothing bad her. > * Uses malloc, bypassing the zend engine memory manager, which requires > strings returned by discount to be copied for use with PHP. Happens in all libraries we use, nothing too bad neither. > I think the best option would be to deprecate the current markdown package > (which only has an alpha release, so the users shouldn't even interface > stability) in favor of mine. Not going to happen but as I said earlier a merge is possible. I will take a look at the new version of the library and see what are the best options. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org