Re: New Extension - PHP-XCB

On Sat, Mar 5, 2011 at 6:51 AM, Davin Thompson <dthompso99@gmail.com> wrote: > Hello all, > > My name is Davin Thompson (dthompso99 on irc), and by way of a pet project > of mine... have developed a new php extension, php-xcb.   XCB is the modern > replacement to xlib, and is the primary interface to X11.  At present, most > window management functions, and some primitive graphics are in place... > but more to come > > Anywho... I thought i would throw this out there for the pecl community to > review.. I've currently hosted the code to google while i work on > documentation and missing features:   > http://code.google.com/p/php-xcb/ Looks interesting and it can find it's home in PECL. But, 2 things: 1. Please follow PHP Coding Standards http://svn.php.net/viewvc/php/php-src/trunk/CODING_STANDARDS?view=markup 2. You, probably, shouldn't store connection in global variables. Try to imagine what would happen in multithreaded environment. This should either be wrapped in object/resource or stored in thread-safe globals (see XCB_G and ZEND_BEGIN_MODULE_GLOBALS in your php_xcb.h) -- Alexey Zakhlestin, http://twitter.com/jimi_dini http://www.milkfarmsoft.com/