Re: Re: [PECL-DEV] We have written an extension for PHP, please have alook at it

Hi, I have changed the BSD license into PHP，thank you for pointing it out. About the tests and the package.xml file, we will add them soon. thanks, Angela 2011-12-19 Angela Song 发件人： Derick Rethans 发送时间： 2011-12-16 19:16:50 收件人： angela.song 抄送： pecl-dev 主题： Re: [PECL-DEV] We have written an extension for PHP, please have alook at it Hi, On Fri, 16 Dec 2011, angela.song wrote: > Name ConstCache > Summary A C extension for PHP > Maintainers < angela.song@kunlun-inc.com> (lead) > License PHP Some files in the repository say that's a new BSD license though (such as in https://github.com/angelasong/ConstCache/blob/master/src/assoc.c). Some files that have the PHP header, don't mention an author and have -2008 in the copyright header. > Link to the code https://github.com/angelasong/ConstCache Looks all quite good to me; I can't see any issues after a cursory glance. However, I do miss a few things: a tests/ directory, and documentation in phpdoc format. You also probably want to create a package.xml file so that you can install it with the pecl installer. cheers, Derick -- http://derickrethans.nl | http://xdebug.org Like Xdebug? Consider a donation: http://xdebug.org/donate.php twitter: @derickr and @xdebug