Re: Package Proposal: Userland Posix Threading

Hi Joe, you could also make it 5.4 compatible easy i think, compiling with 5.4 NTS see the following: In file included from /home/weltling/tmp/php_pthreads/php_pthreads.c:42: /home/weltling/tmp/php_pthreads/pthreads_object.h: In function â?~pthreads_attach_to_instanceâ?T: /home/weltling/tmp/php_pthreads/pthreads_object.h:62: error: â?~zend_class_entryâ?T has no member named â?~default_propertiesâ?T Just look at the other PECL extensions, fixing the default propertios thing is trivial. Regards Anatoliy On Sun, September 2, 2012 14:35, Anatoliy Belsky wrote: > Hi Joe, > > just tried to compile on 5.4 NTS, there are some errors > > /home/weltling/tmp/php_pthreads/pthreads_object.h: In function > â?~pthreads_attach_to_instanceâ?T: > /home/weltling/tmp/php_pthreads/pthreads_object.h:54: error: â?~tsrm_lsâ?T > undeclared (first use in this function) > /home/weltling/tmp/php_pthreads/pthreads_object.h:54: error: (Each > undeclared identifier is reported only once > /home/weltling/tmp/php_pthreads/pthreads_object.h:54: error: for each > function it appears in.) > /home/weltling/tmp/php_pthreads/pthreads_object.h:62: error: > â?~zend_class_entryâ?T has no member named â?~default_propertiesâ?T > > If that's supposed to work with TS versions only, may be config.m4 should > have a check. But i'm also see no reason why it couldn't work on NTS. > > Generally it's a great idea to have threads, despite it's very hard to > ensure it works properly especially under certain SAPIs. Have you tested > for instance apache worker and prefork? CLI might be fine, IMO you should > have a lot of tests to cover it. > > Keep it up > > Anatoliy > > On Sat, September 1, 2012 13:45, Joe Watkins wrote: >> I've written an implementation of userland threads for PHP5+ ( tested >> with 5.3.16 on x86 and x64, varying hardware ). >> >> What must I do to move forward ? >> >> https://github.com/krakjoe/pthreads >> >> Above is a link to the repository as it stands ... all intended features >> are working with a couple of issues remaining ( none of which there is >> no work around for ). >> >> I think it's ready for a wider audience, please advise. >> >> Regards >> Joe Watkins >> >> -- >> PECL development discussion Mailing List (http://pecl.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > > > > -- > PECL development discussion Mailing List (http://pecl.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >