回复： [PECL-DEV] PackageProposal: Userland Posix Threading

Hey Joe 在 2012年9月2日星期日，下午11:06，Joe Watkins 写道： > On 02/09/2012 12:55, Reeze Xia wrote: > > Hi Joe. > > > > 在 2012年9月1日星期六，下午7:45，Joe Watkins 写道： > > > > > I've written an implementation of userland threads for PHP5+ ( tested > > > with 5.3.16 on x86 and x64, varying hardware ). > > > > > > What must I do to move forward ? > > > > > > https://github.com/krakjoe/pthreads > > > > > > Above is a link to the repository as it stands ... all intended features > > > are working with a couple of issues remaining ( none of which there is > > > no work around for ). > > > > > > > > > Thanks for your work, after a quick look, I thought you might want to > > follow PHP's coding standard: > > https://github.com/php/php-src/blob/master/CODING_STANDARDS > > in your extension > > > > And any chance to add some test cases? > > > > Best Regards > > > > > > I think it's ready for a wider audience, please advise. > > > > > > Regards > > > Joe Watkins > > > > > > -- > > > PECL development discussion Mailing List (http://pecl.php.net/) > > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > > > > > All done I think, let me know what to do now, and thanks for your help :) > > There are still some little improvements eg, missing space after 'if'. but they are not big issues :) the next step, I guess is waiting for more question come from other people, if no any questions, maybe someone with karma will guide you what to do next :) Best, > > Cheers