RE: Bug #63002 [Com]: Access Violation 0xc0000005 errors caused by Wincache

Ah, yes, good catch. I'll update now. Thx! --E. > -----Original Message----- > From: pvasilevich at parallels dot com [mailto:pecl-dev@lists.php.net] > Sent: Tuesday, October 23, 2012 11:19 AM > To: donraman@php.net; ksingla@php.net; ruslany@php.net; ericsten@php.net > Subject: Bug #63002 [Com]: Access Violation 0xc0000005 errors caused by > Wincache > > Edit report at https://bugs.php.net/bug.php?id=63002&edit=1 > > ID: 63002 > Comment by: pvasilevich at parallels dot com > Reported by: pvasilevich at parallels dot com > Summary: Access Violation 0xc0000005 errors caused by > Wincache > Status: Closed > Type: Bug > Package: WinCache > Operating System: Windows 2008R2 > PHP Version: 5.4.6 > Assigned To: ericsten > Block user comment: N > Private report: N > > New Comment: > > Hello ericsten, > > as I see you have commited 2 of 3 changes proposed in patch. There is > still problem that could bring access violation crash: > > --- wincache_opcopy.c (revision 328119) > +++ wincache_opcopy.c (working copy) > @@ -3316,6 +3316,12 @@ > if(ozendcl->parent != NULL) > { > clvalue[index].pcname = OSTRDUP(popcopy, ozendcl->parent- > >name); > + if (clvalue[index].pcname == NULL) > + { > + result = popcopy->oomcode; > + goto Finished; > + } > + > zend_str_tolower(clvalue[index].pcname, > strlen(clvalue[index].pcname)); > } > else > > > It will be nice if you add this patch as well. > > > Previous Comments: > ------------------------------------------------------------------------ > [2012-10-23 16:58:19] ericsten@php.net > > Automatic comment from SVN on behalf of ericsten > Revision: > http://svn.php.net/viewvc/?view=revision&revision=328118 > Log: Updating version number for fix of bug 63002 > > ------------------------------------------------------------------------ > [2012-10-23 16:50:21] ericsten@php.net > > The fix for this bug has been committed. > > Snapshots of the sources are packaged every three hours; this change will > be in the next snapshot. You can grab the snapshot at > http://snaps.php.net/. > > For Windows: > > http://windows.php.net/snapshots/ > > Thank you for the report, and for helping us make PHP better. > > > > ------------------------------------------------------------------------ > [2012-10-23 16:49:14] ericsten@php.net > > Fix applied to PHP 5.4.x branch with SVN revision 328115 > > ------------------------------------------------------------------------ > [2012-09-03 03:24:37] pvasilevich at parallels dot com > > Description: > ------------ > Wincache 1.3.4 and PHP 5.4.6 > > There is reliability problem caused by incorrect handling of memory > allocation errors. > > > > Test script: > --------------- > Unfortunately, there are no test script to reproduce this problem. This > problem appears suddenly, only if memory cannot be allocated in specified > code areas. > > I can provide 2 crash dumps for both problems if necessary. > > Please review and apply provided patch. After applying this patch I > haven't found any reliability issues anymore. > > Expected result: > ---------------- > No Access Violation errors > > Actual result: > -------------- > Crash of PHP process > > > ------------------------------------------------------------------------ > > > > -- > Edit this bug report at > https://bugs.php.net/bug.php?id=63002&edit=1 > >