Re: suggested improvement for bug21131.phpt

The test and the seeking are indeed bogus; stdio does not guarantee that the position reported by ftell() will be correct for file descriptors opended in append mode. I thought that I committed a revised test-case to one of the branches that *did* test the original reported case, but I got sidetracked with work, so I'm not entirely sure atm. I will take a look in the morning. I would be interested to see your patch though. --Wez. On Fri, 14 Mar 2003, Sander Roobol wrote: > On Thu, Mar 13, 2003 at 04:00:53PM -0500, David Hill wrote: > > Hi, > > while looking at a reported bug, I found that > > > > ext/standard/tests/file/bug21131.phpt > > > > almost tested the reported case. The report was that fopen("","a+") > > was > > not going to the end. When looking at the test case, I could see that > > the test was using "a+", but as it was not writing anything at that > > point, it seemed to not test my case..... With the addition of one line > > and a slight change to the output, I found that I had a good test case > > and that I could not reproduce the problem :-). Perhaps you might like > > to add my changes to the test (or let me know and I will make the change). > > This test has been removed because it was bogus. Your patch might fix > that, though. Wez? > > Sander > > >