Re: php build on FreeBSD 4.8 /usr/local/ports/lang/php4

Hi, On Thursday 04 September 2003 22:00, Brent Bolin wrote: > strtotime() function [ext/standard/tests/time/002.phpt] > Check for mktime with out-of-range parameters > [ext/standard/tests/time/003.phpt] > Bug #13142 strtotime handling of "M d H:i:s Y" format > [ext/standard/tests/time/bug13142.phpt] > mktime() [ext/standard/tests/time/mktime.phpt] The tests with 'US/Eastern' timezone are bogus for 4.4BSD implementations (I know it also affects BSDi 4.x), as these use the 'city names' approach. Interesting reading on this topic: http://ftp.us.xemacs.org/ftp/pub/freebsd/FreeBSD-current/src/usr.sbin/zic/Theory A more generic fix on these testcases, could probably be done as attached example, but I'm not sure if OSF falls back to GMT as well. tzset(3) on FreeBSD explicetely mentions this in the man page: If the TZ environment variable does not specify a tzfile(5)-format file and cannot be interpreted as a direct specification, UTC is used. If Derick has no objections, I'll fix up the rest of the tests and commit them tommorrow. RE: mktime bugs - I recall this has something to do with php's compensation for DST, but I'll check under gdb tommorow. -- Melvyn

Attachment: [text/x-diff] fixtest.patch