Re: Re: ext/wddx/tests/001.phpt

From: Date: Sun, 04 Apr 2004 19:01:56 +0000
Subject: Re: Re: ext/wddx/tests/001.phpt
References: 1 2 3 4 5  Groups: php.qa 
Request: Send a blank email to php-qa+get-16131@lists.php.net to get a copy of this message
On 2004/04/05, at 3:54, Derick Rethans wrote:
On Mon, 5 Apr 2004, Moriyoshi Koizumi wrote:
P.S. could you also take a look at ext/mbstring/config.m4, as you seem to have unintentionally inverted a testing logic?
I don't think I inverted it, I changed "|| ! test" to "-o !".
http://cvs.php.net/diff.php/php-src/ext/mbstring/config.m4?r1=1.46&r2=1.47&ty=h 1.46: test "$ext_shared" = "no" || ! test -e "$ext_builddir/config.h.in"; then 1.47: test "$ext_shared" = "no" -o -e "$ext_builddir/config.h.in" Therefore it should have been test "$ext_shared" = "no" -o ! -e "$ext_builddir/config.h.in" which is the exact form that caused build failure with Solaris' sh. See also this one: http://cvs.php.net/diff.php/php-src/ext/mbstring/config.m4?r1=1.44&r2=1.45&ty=h Moriyoshi

« previous php.qa (#16131) next »