Re: array_diff, array_diff_ukey, array_diff_uassoc tests
| From: | Marcus Boerger | Date: | Sat, 27 May 2006 00:22:47 +0000 |
| Subject: | Re: array_diff, array_diff_ukey, array_diff_uassoc tests | ||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-26795@lists.php.net to get a copy of this message | ||
Hello Ligaya,
i looked into your tests and modified them a bit. However they do not
seem to make sense to me and for array_diff_u*.phpt i get different
results than you do. So who is the right one to look into these. Lukas
came directly into my mins as well as Andrei, adding them as recipient.
What i changed:
- I converted the files to unicode - all tests should be nicode files
as that is the standard for php.
- I switched from print_r to var_dump in array_diff_2.phpt. Actually
i would have done that for the other two as well, but i am unsure
about the correct resul, so i left those. The difference is that
using var_dump we check that the functions behave corrsponding to
unicode setting. Also var_dump() differenciates between NULL, ""
and flase.
- I dropped the wrapper array around the results becuase there is no
need for that.
- I added "===DONE===" at the end of the actual scripts after the ending
"?>". That is a thing we started when we found out that some tests
work to that point but have a problem after the closing "?>".
Best regards,
Marcus