Re: Updates to the QA web site
| From: | Zoe Slattery | Date: | Mon, 04 Jun 2007 14:48:50 +0000 |
| Subject: | Re: Updates to the QA web site | ||
| References: | 1 2 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-33263@lists.php.net to get a copy of this message | ||
Antony Dovgal wrote:
I personally don't really like the part that tells how to use basename() - IMO it's a bit overcomplicated. I believe it's much easier to write "fred.tmp" twice than strip suffixes and do other magical stuff just to save few keystrokes. So I'd propose to avoid frightening people with this stuff and go the easiest route =) Yes - I admit that I wasn't sure about that, although I wasn't trying to save keystrokes. The logic for puttting it in was that (a) it was suprisingly hard to work out how to do it and if I wanted to I guess someone else might, (b) if all test cases generate "fred.tmp" it will be a pain trying to find out which of them has not removed it correctly :-)I think you are right since it's not a construct that is partucularly easy to understand if you are trying to read someone else's test. How about I remove the example but add some text suggesting that people call the temporary files by some name that relates them to the test case? I guess if there is a re-write of run-tests.php it might be nice if this was a little easier to do?
The other parts look fine, here is the diff: http://dev.daylessday.org/diff/write_tests_clean.diff Thanks!