Re: Re: cvs: php4(PHP_4_0_7) /ext/standard var.c

On December 2, 2001 02:54 am, Zeev Suraski wrote: > At 11:48 02/12/2001, Zak Greant wrote: > >On December 2, 2001 02:42 am, Thies C. Arntzen wrote: > > > On Sat, Dec 01, 2001 at 11:51:26PM +0200, Zeev Suraski wrote: > > > > By the way, if you (personally:) give these patches a second thorough > > > > look, perhaps they can go into RC5 (it does make working with > > > > $_SESSION slightly better). I'm simply afraid that because I'm not > > > > too familiar with the session code, I may have introduced some quirk > > > > or bug... > > > > > > i'm not familiar with that code as well. but as this is a > > > problem with the now recommented register_globals=off setting > > > i think it should be fixed in 4.1. > > > > > > qa-team - question is: merge those fixes or not? > > > > IMO we should merge them and then do some seriously testing > > of these changes. I would hate for 4.1.0 to be released, only to > > have > > to watch you guys roll a PL a little bit later. > > It's not a pl issue... It's a matter of functionality, not a bug. I don't mean that we would need a PL for adding the functionality. :) I mean that we should make sure to test the functionality so that we don't need to have a PL to fix any nasty bugs that slipped in with the feature. -- Zak Greant PHP Quality Assurance Team http://qa.php.net/ "We must be the change we wish to see." - M. K. Ghandi