Re: CVS ChangeLog Commentary

> +2001-12-30 Zak Greant <zak@jobvillage.com> > + > + * ext/standard/dir.c: > + chdir: corrected proto, converted to zend_parse_parameters > + > + * ext/standard/dir.c: > + chroot: corrected prototype, converted to zend_parse_parameters > + > + * ext/standard/basic_functions.c: > + Converted getenv to use zend_parse_parameters > > Relatively minor changes - unlikely to break anything, however we > should keep an eye on them. Btw, zend_parse_parameters is slower than the working code you removed.. one really should not implement zend_parse_parameters just because it looks nicer. Using it for new code is cool, while throwing out existing code is a somewhat deliberate decision. > Replaced a call to estrdup with a call to safe_estrdup > These macros are basically the same - except that safe_estrdup > returns an empty string if the pointer passed to safe_estrdup > is NULL? > > The change should do nothing other than fix the crash from the > attempt to duplicate a null pointer. > > (Someone with a clue about the code: Is the above synopsis right? :) Yes > Additionally, there are no regression tests for this extension. > We may want to take a look at this... :) You might want to take a look at ext/session/tests. - Sascha Experience IRCG http://schumann.cx/ http://schumann.cx/ircg