2002-01-04 CVS ChangeLog Comment Summary

A lot of fixes and minor changes to the m4 files over the last couple of days. While the changes look inoccuous, given the importance of these files, the QA team should try to test this in the next RC. --zak +2002-01-04 Jon Parise <jon@csh.rit.edu> + * main/rfc1867.c: Nuke unused variable warning (end_arr). Removed the declaration for an unused variable. Should, dare I say can, not break anything. :) +2002-01-04 Stig Venaas <venaas@uninett.no> + + * ext/ldap/ldap.c + ext/ldap/php_ldap.h: + Made ldap_modify() an alias for ldap_mod_replace(). The two were + identical. Yup. Should not break anything. :) +2002-01-04 jim winstead <jimw@apache.org> + + * ext/standard/tests/strings/wordwrap.phpt + ext/standard/string.c: + Fixed segfault in wordwrap() when wrapping to zero width and using + multi-character break or trying to force cut (bug #12768, now fails + and issues a warning because forcing a zero-width cut doesn't make + sense). Also converted to new paramater-passing API and avoid making + an extra copy of the return values. If more people wrote commit messages like Jim, I would have a lot less to do. :) While the changes are nice and clean (Yup, it feels odd to say this given how crummy my C skills are :>), and Jim was kind enough to write a test for for this, we should still watch out for problems. Also, kudos to Jim for the recent enhancements to the bug reporting system. +2002-01-04 Sterling Hughes <sterling@designmultimedia.com> + + * ext/dio/dio.c: Added the O_NOCTTY option, for terminal i/o. dio is fairly new and experimental - this is another good candidate for testing in the next RC. However, given that it is based on very stable functionality, we should not see too many problems. I would guess that the biggest possible issue would be platform based issues. One interesting little bit of code is the macro that Sterling used for handling constant definitions - nice way to get past stupid typing errors. :) #define RDIOC(c) REGISTER_LONG_CONSTANT(#c, c, CONST_CS | \ CONST_PERSISTENT) +2002-01-04 Hartmut Holzgraefe <hartmut@six.de> + + * configure.in: first PHP_EXTENSION_LIBS casualty :( I have no idea what is going on here. I am going to ask Hartmut for some pointers. :) +2002-01-04 Ben Mansell <ben@zeus.com> + + * sapi/fastcgi/fastcgi.c: + Added log_message function to the FastCGI sapi, so you can see error + output from scripts A useful change. :) Does anyone here use FastCGI? +2002-01-04 Hartmut Holzgraefe <hartmut@six.de> + + * ext/ncurses/config.m4: ncurses is useless in webserver modules There was an objection to this change from Edin Kadribasic <edink@proventum.net> "... But I don't think we should be preventing building extensions if they are being compiled as modules. That makes building a command line interpreter and server module with the same configure line more difficult." + * ext/xmlrpc/config.m4 + ext/xslt/config.m4: more unquoted messages with kommas fixed + + * ext/mcrypt/config.m4: + always quote messages with [...], *especialy* when using kommas in the text + + * ext/domxml/php_domxml.c: proto fixes + + * ext/pcntl/config.m4: use predefined function instead of hardcoded test + + * ext/pcntl/pcntl.c + ext/odbc/velocis.c: proto fix + + * CODING_STANDARDS: small clarification A bunch of innocuous changes :) +2002-01-04 Sascha Schumann <sascha@schumann.cx> + + * genfiles: Remove #line's from var_unserializer.c Err... Sascha stuff going on here. :) The change is a minor one that strips #line directives from ext/standard/url_scanner_ex.c and ext/standard/var_unserializer.c (instead of just from the former file) ext/standard/url_scanner_ex.c and ext/standard/var_unserializer.c are generated by re2c (http://www.tildeslash.org/re2c/) - a tool that helps to generate fast lexers based on regular expressions. The #line lines that are being removed from the code are preprocessor directives that pass false line numbers to the compiler as an aid to debugging. I would guess that the line numbers in the #line directives correspond to line numbers in the source file that is fed to re2c. :) +2002-01-04 Hartmut Holzgraefe <hartmut@six.de> + + * ext/readline/config.m4: check for library existance before adding them See Edin's objection above - this is a similar situation. I don't feel that this is a big issue - it will help more users than harm them. + * acinclude.m4: two new check functions for use in config.m4 file Hartmut added PHP_CHECK_INTERACTIVE and PHP_CHECK_STANDALONE that are required by a good number of the changes that he has made to the m4 files. These functions test if PHP is being built as a CGI. If it is not, then an error message is generated. +2002-01-04 Sebastian Bergmann <sb@sebastian-bergmann.de> + * ext/mssql/.cvsignore: Update .cvsignore. Nothing to worry about here.