Re: Just needed one more day.....
| From: | (Marcus Börger) | Date: | Sun, 10 Mar 2002 23:56:51 +0000 |
| Subject: | Re: Just needed one more day..... | ||
| References: | 1 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-4488@lists.php.net to get a copy of this message | ||
Just took a closer look and very much testing on all code especially
code left from jhead. I found 4 things that need to changed:
in image.c
- a missing efree (affects getimagesize on TIFF)
in exif.c
- a strcopy where strncpy is needed in (affects exif_read_data on damaged images)
- a missing string check (from olympus support by jhead)
- incorrect result generation check (shouldn't be a real problem but code is wrong
so it may become one)
if you approove to the changes i will fix them in 4.2
marcus
At 00:42 09.03.2002, Derick Rethans wrote:
Hello Marcus,
I need to check this a little bit more, but have no time currently. I'll
check it on Monday.
Derick
On Fri, 8 Mar 2002, Marcus Boerger wrote:
Hi Release Master,
you should consider merging actual version of ext/standard/image.c and
version 1.54
of ext/exif/exif.c both add support for non digital camera TIFF files. I
think we will get
a bunch of entries in bug database on that otherwise. Code is checked and
seems clean.
As far as i remember you do not need to change any other file for that.
Detecting the problem took me one more day...
regards
marcus
--------->>> mailto:marcus.boerger@post.rwth-aachen.de <<<------------
I don't want to start any blashphemous rumours
but i think that god's got a sick sense of humor
and when i die i expect to find him laughing.
Depeche Mode
--------------->>> http://www.marcus-boerger.de <<<-------------------