Re: cvs: php4(PHP_4_2_0) /ext/domxml php_domxml.c

On Wed, 13 Mar 2002, Derick Rethans wrote: > Hey Christian, > > what are we merging here? just 3 (öhm 6, with the previous commit) lines :) With that, attribute nodes return something as well in node_name(). you can call it a bugfix, since it's expected, that attribute (and document) nodes also return something, according to W3C specs. it's not really a new feature or new functionality, but if I was not allowed to do it, i will of course revert it. christian > > Derick > > On Wed, 13 Mar 2002, Christian Stocker wrote: > > > chregu Wed Mar 13 03:15:55 2002 EDT > > > > Modified files: (Branch: PHP_4_2_0) > > /php4/ext/domxml php_domxml.c > > Log: > > Return attribute name in node_name(), if it's a XML_ATTRIBUTE_NODE > > > > > > > > Index: php4/ext/domxml/php_domxml.c > > diff -u php4/ext/domxml/php_domxml.c:1.118.2.5 php4/ext/domxml/php_domxml.c:1.118.2.6 > > --- php4/ext/domxml/php_domxml.c:1.118.2.5 Wed Mar 13 02:38:14 2002 > > +++ php4/ext/domxml/php_domxml.c Wed Mar 13 03:15:54 2002 > > @@ -16,7 +16,7 @@ > > +----------------------------------------------------------------------+ > > */ > > > > -/* $Id: php_domxml.c,v 1.118.2.5 2002/03/13 07:38:14 chregu Exp $ */ > > +/* $Id: php_domxml.c,v 1.118.2.6 2002/03/13 08:15:54 chregu Exp $ */ > > > > /* TODO > > * - Support Notation Nodes > > @@ -1437,6 +1437,10 @@ > > > > case XML_TEXT_NODE: > > str = "#text"; > > + break; > > + > > + case XML_ATTRIBUTE_NODE: > > + str = n->name; > > break; > > > > case XML_CDATA_SECTION_NODE: > > > > > > > > -- > > PHP CVS Mailing List (http://www.php.net/) > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > Derick Rethans > > --------------------------------------------------------------------- > PHP: Scripting the Web - www.php.net - derick@php.net > All your branches are belong to me! > SRM: Site Resource Manager - www.vl-srm.net > --------------------------------------------------------------------- > -- nam...christian stocker adr...bremgartnerstr. 66, ch-8003 zurich pho...+41 1 451 6021 www...http://phant.ch/chregu mob...+41 76 561 8860 ema...chregu@phant.ch wor...+41 1 240 5670 gpg...0x5CE1DECB