Re: MFH for 2 zlib patches?

On 2002-03-13 19:32:09, Derick Rethans wrote: > Strings used in the PHP zval container should always be \0 terminated, so > this not a problem. (Unless another module screws things up). This fix > should go in. Good. So the one extra byte really doesn't matter (and in most cases it shouldn't be read anyway). > I think this can be merged too. WOuld you be so kind to hand over some > test cases (more than just the tests dir) to the QA team, so this can be > properly tested during RCs? Ok, I'll commit these two patches. For the first problem, I don't have more tests, the problem happens only with special input data, the 15 'a's is the only example I have (you can vary the 15 a little bit and you can change the letter, but in principle I don't have really new tests). For gzencode() I think the best testing method would be, if you take arbitray strings, gzencode() them and feed it to gzip -t or compare the string to the output of gzip -c . But I don't know if that's allowed in your testing environment (gzip normally isn't avalaible on windows ...). Stefan -- Stefan Röhrich stefan@roehri.ch, sr@linux.de http://www.roehri.ch/~sr/